search

PIP-Technical-Team / pipapi

What the Package Does (One Line, Title Case)
https://pip-technical-team.github.io/pipapi/
Other
3 stars 0 forks source link

Fix col selection #380

Closed tonyfujs closed 1 year ago

tonyfujs commented 1 year ago

Clean-up of column selection of the returned object for various pipapi function. Many were hard-coded in multiple places, I tried to partially solve it by building on the approach used in the pip() function with lkup$pip_cols.

@shahronak47 Please make sure all the tests are passing. A couple of pip_grp_logic failed inconsistently. I could not figure out why.

Also, there is definitely still room for improvement, so please do not hesitate to make suggestions if you spot areas taht can be improved.

Thanks!

shahronak47 commented 1 year ago

Hi @tonyfujs , the tests pass for me and rest of code looks fine to me.

image

I noticed that there are quite a few error/warnings/notes generated from devtools::check(). I have tried to fix some of them in this PR https://github.com/PIP-Technical-Team/pipapi/pull/381