search

PIP-Technical-Team / pipapi

What the Package Does (One Line, Title Case)
https://pip-technical-team.github.io/pipapi/
Other
3 stars 0 forks source link

Add test for median and SPL in fillgaps = TRUE #388

Closed randrescastaneda closed 1 year ago

tonyfujs commented 1 year ago

Thanks @randrescastaneda Do all tests pass for you? I have some failing... image

randrescastaneda commented 1 year ago

That's very weird. All tests passed to me. I'll check.

R.Andrés Castañeda

Ps: I apologize for typos and brevity. Sent from my iPhone

Development Economics, Data Group +1 (202) 473-0108 | Room MC 2-860 randrescastaneda.rbind.io The World Bank Group

From: Tony Fujs @.> Sent: Friday, November 10, 2023 5:09:50 AM To: PIP-Technical-Team/pipapi @.> Cc: R.Andres Castaneda Aguilar @.>; Mention @.> Subject: Re: [PIP-Technical-Team/pipapi] Add test for median and SPL in fillgaps = TRUE (PR #388)

[External]

Thanks @randrescastanedahttps://github.com/randrescastaneda Do all tests pass for you? I have some failing... [image]https://user-images.githubusercontent.com/1552634/282027322-c0e2e759-abb4-4e64-b0b4-6e8c1b98985d.png

— Reply to this email directly, view it on GitHubhttps://github.com/PIP-Technical-Team/pipapi/pull/388#issuecomment-1805443851, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AINKU3KTYWLBMCU35R3RLR3YDX4O5AVCNFSM6AAAAAA7FRNTU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVGQ2DGOBVGE. You are receiving this because you were mentioned.Message ID: @.***>

randrescastaneda commented 1 year ago

Tony, did you check your cache? As far as I can see, you're getting no medians at all. Am I missing somethin?

R.Andrés Castañeda

Ps: I apologize for typos and brevity. Sent from my iPhone

Development Economics, Data Group +1 (202) 473-0108 | Room MC 2-860 randrescastaneda.rbind.io The World Bank Group

From: R.Andres Castaneda Aguilar @.> Sent: Friday, November 10, 2023 7:05:15 AM To: PIP-Technical-Team/pipapi @.>; PIP-Technical-Team/pipapi @.> Cc: Mention @.> Subject: Re: [PIP-Technical-Team/pipapi] Add test for median and SPL in fillgaps = TRUE (PR #388)

That's very weird. All tests passed to me. I'll check.

R.Andrés Castañeda

Ps: I apologize for typos and brevity. Sent from my iPhone

Development Economics, Data Group +1 (202) 473-0108 | Room MC 2-860 randrescastaneda.rbind.io The World Bank Group

From: Tony Fujs @.> Sent: Friday, November 10, 2023 5:09:50 AM To: PIP-Technical-Team/pipapi @.> Cc: R.Andres Castaneda Aguilar @.>; Mention @.> Subject: Re: [PIP-Technical-Team/pipapi] Add test for median and SPL in fillgaps = TRUE (PR #388)

[External]

Thanks @randrescastanedahttps://github.com/randrescastaneda Do all tests pass for you? I have some failing... [image]https://user-images.githubusercontent.com/1552634/282027322-c0e2e759-abb4-4e64-b0b4-6e8c1b98985d.png

— Reply to this email directly, view it on GitHubhttps://github.com/PIP-Technical-Team/pipapi/pull/388#issuecomment-1805443851, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AINKU3KTYWLBMCU35R3RLR3YDX4O5AVCNFSM6AAAAAA7FRNTU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVGQ2DGOBVGE. You are receiving this because you were mentioned.Message ID: @.***>

tonyfujs commented 1 year ago

Duh! That was indeed the issue. I had not disabled the cache. Everything's good now. Merging.