search

PIP-Technical-Team / pipapi

What the Package Does (One Line, Title Case)
https://pip-technical-team.github.io/pipapi/
Other
3 stars 0 forks source link

Improve cache for cp #392

Closed shahronak47 closed 9 months ago

shahronak47 commented 10 months ago

To improve caching make the pip call for all countries.

randrescastaneda commented 9 months ago

Hi @tonyfujs ,

This PR incorporates the changes that optimize the call in Country Profiles page. Running the pre cache with this should be extremely fast. I agreed with the changes, but please I would like to make sure you agree with the changes.

Thanks.

randrescastaneda commented 9 months ago

Looks good to me too.

  • All tests passed
  • Local Postman regression testing passed
  • I removed caching to the ui_cp_charts and ui_cp_key_indicators functions as it is no longer needed
  • I tested the new caching mechanism, and endpoints are returning really fast once they have been cached.

Fantastic. Thank you, Tony. I'll merge then.