PIP-Technical-Team / pipdm

What the Package Does (One Line, Title Case)
https://pip-technical-team.github.io/pipdm/
Other
0 stars 0 forks source link

Call wbpip ::: directly #107

Closed Aeilert closed 2 years ago

Aeilert commented 2 years ago

Hi @randrescastaneda, @tonyfujs

In an early development stage of this package I wanted to reduce the number notes and warnings in R CMD check. One cause of such notes/warnings is the cross-use of internal functions from another package (see https://github.com/PIP-Technical-Team/wbpip/pull/92).

I therefore added the following type of hacks

#' md_clean_data
#' Copied from wbpip to avoid notes in R CMD CHECK.
#' @noRd
md_clean_data <-
  utils::getFromNamespace("md_clean_data", "wbpip")

This does - admittingly - however add a layer of unnecessary complexity to the code. So as part of the code cleaning I suggest removing it.