PIP-Technical-Team / pipdm

What the Package Does (One Line, Title Case)
https://pip-technical-team.github.io/pipdm/
Other
0 stars 0 forks source link

Fix svy selection #99

Closed tonyfujs closed 2 years ago

tonyfujs commented 2 years ago

Hi @Aeilert

The issue is fixed now. You'll see that I've fixed by only modifying the get_closest_surveys() function. Probably not the cleanest way to solve the whole selection issue conceptually, but since the change is contained to one function, it won't break anything in the pipeline.

I also added a full suite of unit test checking each leaf of Daniel's decision tree.

I've also made a few minor changes. Please look at the commit messages for the rational. Thanks!