search

PIP-Technical-Team / wbpip

Official methodological Stats of PIP
https://pip-technical-team.github.io/wbpip/
Other
3 stars 1 forks source link

Implement md_compute_poverty_stats() for microdata #2

Closed tonyfujs closed 4 years ago

tonyfujs commented 4 years ago

md_compute_poverty_stats(welfare, weight, povline) This functions returns all poverty stats sensitive to the poverty line.

R implementation of PovcalNet code is available here starting on line 133: https://github.com/PovcalNet-Team/povcalnet/blob/master/R/nonParam.R

ifeanyi588 commented 4 years ago

Dear @tonyfujs,

I think I have completed this task. Please look take a look at the test function I wrote and let me know what you think. I sense that there is probably more I could do but I am not sure what else you would like to see.

Best regards, Ify

ifeanyi588 commented 4 years ago

Dear @tonyfujs

I just wanted to confirm that I have just added a test that compares results from md_compute_poverty_stats() to the outputs of nonParam() in the povcalnet package. The results match but perhaps we need to have a discussion about how much work we want the consumer to do in estimating the poverty line. I had to debug nonParam() and calculated pl_LCU and then used it as the argument for povline before my function output could match? In other words, req.PovertyLine in nonParam() is not the same as povline in md_compute_poverty_stats().

Best regards, Ify

randrescastaneda commented 4 years ago

Hi @ifeanyi588 ,

If you think this task is done, please create a pull request and add @tonyfujs as reviewer.

Thanks. Best,