PIP-Technical-Team / wbpip

Official methodological Stats of PIP
https://pip-technical-team.github.io/wbpip/
Other
3 stars 1 forks source link

Vectorization and other changes to value_at #239

Closed dana89co closed 6 months ago

dana89co commented 8 months ago
  1. Vectorization of value_at_lq only (for value_at_lb it was not necessary)
  2. Add error if any value in vector is negative, NA or Inf
  3. Tests for new value_at_lq and new check functions
dana89co commented 8 months ago

Task linked: CU-8686rcmv0 vectorize inefficient functions in wbpip

randrescastaneda commented 6 months ago

Hola @dana89co ,

Could you please change this PR to merge into dev_stage2 branch? Also, please make sure the PR is free of conflicts. Thank you!

dana89co commented 6 months ago

Hola @randrescastaneda, I should have closed this PR before because, if I am not mistaken, these changes were already included on dev_stage2 when I did the following PR: https://github.com/PIP-Technical-Team/wbpip/pull/244. I am sorry.