Fix BlockCache bug in attaching detached blocks in the presence of reorgs

[bigspider]

The fix is 1 line in BlockCache.processDetached. The rest of the diff is:

• the test for the bug condition
• improvements on the BlockCache tests (generateBlocks had an off-by-one)
• removed stale function getConfirmation and its tests; we're not using it.