search

PIT-Solutions-Private-Limited / deepltranslate

4 stars 3 forks source link

Error message when translating records as editor #10

Open spoonerWeb opened 4 years ago

spoonerWeb commented 4 years ago

When translating records as editor with DeepL support, the error message "Attempt to modify table 'localization' without permission!" appears.

The translation is working but the error message gives a wrong feedback to the editors.

Problem is that the DeepL config is set in $cmd['localization'].... The first part of the $cmd array is used for table names. As "localization" is no table, the error appears. IMHO it would be better to respect the structure of the cmdmap and put the information maybe on the command level, see: https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/Typo3CoreEngine/Database/Index.html#commands-array

rickymathewkweb commented 4 years ago

@spoonerWeb

We at https://github.com/web-vision has currently forked this extension. Fixed this issue here https://github.com/web-vision/wv_deepltranslate. Feel free to check it out as composer package https://packagist.org/packages/web-vision/wv_deepltranslate.