search

PIVX-Labs / MyPIVXWallet

Send, Stake and Receive with PIVX's most universal wallet.
https://mypivxwallet.org/
MIT License
29 stars 36 forks source link

Persistant Wallet Mode #405

Closed JSKitty closed 1 month ago

JSKitty commented 1 month ago

Abstract

This PR adds Persistance to the "Wallet Mode", effectively treating it as a Setting, persisting the user's preferred Wallet Mode throughout their sessions.

A common usecase example being, a PIVCards user wanting maximum privacy.

  1. User, whom exclusively uses SHIELD, opens a "Pay with MPW" invoice.
  2. MPW loads and opens the Payment UI, which currently defaults to Public.
  3. The user must close the dialog, switch mode, then return to the dialog to continue to pay with SHIELD.

With this PR, assuming they last used MPW in Private mode, the invoice will open with Private mode, and allow a smooth one-click-style payment.

This PR does not affect the 'true default', which remains Public Mode, i.e: when a new wallet is created or imported.

Testing

To test this PR, it's suggested to attempt these user flows, or variations of these:

If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!

netlify[bot] commented 1 month ago

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
Latest commit ec11058553097416138f7a499ddf1e35963b0e07
Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/66fb056603a9640008f0c1ea
Deploy Preview https://deploy-preview-405--cheery-moxie-4f1121.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.