PIVX-Project / PIVX

Protected Instant Verified Transactions - Core wallet.
https://www.pivx.org
MIT License
528 stars 714 forks source link

[Feature Request] Don't force a wallet restart when saving settings #1114

Closed Fuzzbawls closed 4 years ago

Fuzzbawls commented 5 years ago

Opening up this feature request for tracking/discussion as I feel it isn't of critical importance at the moment.

Currently, when saving a setting that requires a wallet restart, there is no option to postpone the restart, and the only progression path is to force the user to allow the wallet to restart itself at the time of settings save.

I think this goes against what has become accepted as "standard practice" (think OS updates), and I can see situations where a user may not wish to restart their wallet right away, and simply choose to have the new settings applied when they themselves choose to restart the wallet.

For reference, here is a list of all settings that set the fRestartRequired flag:

Deprecated or otherwise not currently used settings:

furszy commented 4 years ago

As #1113 was merged, closing this issue.