search

PIVX-Project / PIVX

Protected Instant Verified Transactions - Core wallet.
https://www.pivx.org
MIT License
528 stars 716 forks source link

[Qt] Make "For anonymization and staking only" checked by default #515

Closed realuser closed 6 years ago

realuser commented 6 years ago

This is a feature request. In at least a few other staking wallets (Qtum for example), when you click on Settings->Unlock Wallet... the checkbox to unlock the wallet only for staking is already pre-checked.

I think this should be pre-checked in PIVX too as it may be the most common behavioral path (it is for me at least). Also this would make the default more secure than the current default.

What version of PIVX Core are you using?

PIVX Core version v3.0.6 (64-bit)

Mrs-X commented 6 years ago

I'll do that.

Fuzzbawls commented 6 years ago

Just so it is documented here:

I think it would be wise to use request state information instead of a blanket "default" when calling the GUI's unlock wallet dialog so that the state of the checkbox can be set programatically.

danielelis commented 6 years ago

GUI's unlock wallet dialog with less than 1 PIV → unchecked box GUI's unlock wallet dialog with more than 1 PIV → checked box GUI's unlock wallet dialog with masternodes → unchecked box

Warrows commented 6 years ago

I guess we can close this since #521 is merged and #553 tracks the next step?

Mrs-X commented 6 years ago

Yep, I'll close it.