PJ-Singh-001 / Cubic

The Official Web Site for Cubic (Custom Ubuntu ISO Creator) (https://github.com/PJ-Singh-001/Cubic)
792 stars 46 forks source link

filesystem.manifest-minimal-remove should not contain system-wide language packages from filesystem.manifest-remove #331

Open natanjunges opened 1 month ago

natanjunges commented 1 month ago

Describe the bug

The ubiquity code assumes they are not present in filesystem.manifest-minimal-remove, and specifically uses filesystem.manifest-minimal-remove to only remove language packages of apps removed in minimal install. This results in the language selected during install being removed in a minimal install when using the files generated by Cubic.

To Reproduce

  1. Generate an ISO using Cubic;
  2. When installing it choose a language different from English;
  3. Select the minimal install;
  4. Check the language used in the resulting system.

Expected behavior

The system-wide language packages should be kept in a minimal install.

OS Information (please complete the following information):

Cubic Information (please complete the following information):

natanjunges commented 1 month ago

Checking the original files, there are packages listed in both files: hunspell-*, hyphen-*, libreoffice-help-*, libreoffice-l10n-*, mythes-* and thunderbird-locale-*. They are language packages specific to apps removed in the minimal install.

natanjunges commented 1 month ago

The language packages that should not be present in filesystem.manifest-minimal-remove are gnome-user-docs-*, language-pack-*, language-pack-gnome-* and w*.

PJ-Singh-001 commented 1 month ago

Thanks for the bug and the detailed research!