search

PJCzx / homebridge-thermostat

Supports thermostat devices on HomeBridge Platform
Apache License 2.0
34 stars 71 forks source link

README differs from code #21

Closed paullj1 closed 7 years ago

paullj1 commented 7 years ago

README States:

But index.js appears to accept:

action = "/off";
action = "/comfort"; // Looks like heat
action = "/auto";
action = "/no-frost"; // Looks like cool

Which is correct?

paullj1 commented 7 years ago

So, just tcpdumped it and it looks like the plugin is sending just like the code says: apiroute + action

Which excludes the /targetHeatingCoolingState/ as well.

PJCzx commented 7 years ago

Yes correct, but I'm looking forward to remove it so deprecated. Kept for compatibility. Sent from my mobile device.

Le 1 mai 2017 à 13:59, Paul Jordan notifications@github.com a écrit :

README States:

GET /targetHeatingCoolingState/{INT_VALUE_0_TO_3} But index.js appears to accept:

action = "/off"; action = "/comfort"; // Looks like heat action = "/auto"; action = "/no-frost"; // Looks like cool Which is correct?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

paullj1 commented 7 years ago

Wait, so it only supports one... not both.

On Mon, May 1, 2017 at 11:35 AM Pierre-Julien Cazaux < notifications@github.com> wrote:

Yes correct, but I'm looking forward to remove it so deprecated. Kept for compatibility. Sent from my mobile device.

Le 1 mai 2017 à 13:59, Paul Jordan notifications@github.com a écrit :

README States:

GET /targetHeatingCoolingState/{INT_VALUE_0_TO_3} But index.js appears to accept:

action = "/off"; action = "/comfort"; // Looks like heat action = "/auto"; action = "/no-frost"; // Looks like cool Which is correct?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PJCzx/homebridge-thermostat/issues/21#issuecomment-298368867, or mute the thread https://github.com/notifications/unsubscribe-auth/AIb5B-5A_XETBAMNC2rKM-s7W4VN1zusks5r1gm8gaJpZM4NM_4d .

PJCzx commented 7 years ago

It currently support both, but I'm planning to only stick to the Apple requirement (1,2,3,...) and not to off, comfort, ...

Pierre-Julien Cazaux, Sent from my mobile device.

Le 1 mai 2017 à 19:50, Paul Jordan notifications@github.com a écrit :

Wait, so it only supports one... not both.

On Mon, May 1, 2017 at 11:35 AM Pierre-Julien Cazaux < notifications@github.com> wrote:

Yes correct, but I'm looking forward to remove it so deprecated. Kept for compatibility. Sent from my mobile device.

Le 1 mai 2017 à 13:59, Paul Jordan notifications@github.com a écrit :

README States:

GET /targetHeatingCoolingState/{INT_VALUE_0_TO_3} But index.js appears to accept:

action = "/off"; action = "/comfort"; // Looks like heat action = "/auto"; action = "/no-frost"; // Looks like cool Which is correct?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PJCzx/homebridge-thermostat/issues/21#issuecomment-298368867, or mute the thread https://github.com/notifications/unsubscribe-auth/AIb5B-5A_XETBAMNC2rKM-s7W4VN1zusks5r1gm8gaJpZM4NM_4d .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

PJCzx commented 7 years ago

Btw, I agree what you did with the targetHeatingCoolingState but I added a review on your last commit. Thank for your contribution :)