search

PJCzx / homebridge-thermostat

Supports thermostat devices on HomeBridge Platform
Apache License 2.0
34 stars 71 forks source link

A number of changes #35

Closed phenotypic closed 5 years ago

phenotypic commented 5 years ago

Hi there,

I've been working on my own fork of this plugin for a while, and think I've made some improvements which should be integrated into the main branch. Here's a list of the changes:

  1. Make the README.md clearer
  2. Cleanup and streamline index.js
  3. Added a standalone HTTP function for simplicity (also removed the response code check)
  4. Added a timeout duration to prevent Homebridge from getting stuck if the thermostat is not responding
  5. Solved #32, allowing you to control the temperature via Siri (previously unsupported)
  6. Allows you to specify a custom manufacturer, serial and model
  7. Makes the humidity fields optional (can be enabled individually or together in the config.json as per README.md)

Hopefully you approve of these changes and agree that they improve on the current version. If you have any question, quibbles or suggestions then please feel free to let me know!

Kind regards, Tom

PJCzx commented 5 years ago

Thx @Tommrodrigues for your time. As I do not have much time to invest and since you look to care about this plugin, I both merge your code and thank you a lot for your contribution.

Best, PJCzx