PJCzx / homebridge-thermostat

Supports thermostat devices on HomeBridge Platform
Apache License 2.0
34 stars 71 forks source link

pollInterval does not work #52

Closed lp4so closed 4 years ago

lp4so commented 4 years ago

Hi, I'm pleased with your plugin, but the pollInterval doesn't seem to work.

Thanks.

PJCzx commented 4 years ago

Hello @lp4so could you please be a little bit more explicit (expected behavior and observed ?)

Thx :)

lp4so commented 4 years ago

Bonjour,

Vu ton nom, j’imagine que tu es Français alors ça sera plus simple comme ça 😉

Eh bien, j’ai configuré un pollInterval de 30s, et rien ne se passe après 30s, pas de polling pour détecter les nouvelles valeurs. J’ai maté vite fait le code, et le terme pollInterval n’apparait pas non plus.

Provenance : Courrierhttps://go.microsoft.com/fwlink/?LinkId=550986 pour Windows 10

De : Pierre-Julien Cazauxmailto:notifications@github.com Envoyé le :mercredi 6 mai 2020 09:38 À : PJCzx/homebridge-thermostatmailto:homebridge-thermostat@noreply.github.com Cc : lp4somailto:l.p@live.fr; Mentionmailto:mention@noreply.github.com Objet :Re: [PJCzx/homebridge-thermostat] pollInterval does not work (#52)

Hello @lp4sohttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flp4so&data=02%7C01%7C%7C5d7fe42471cf4920941c08d7f1906b42%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637243474878261150&sdata=idaPaj3NwnEPWc9D2cz3SXaYWZFI6iwnFDl9JX7wW2s%3D&reserved=0 could you please be a little bit more explicit (expected behavior and observed ?)

Thx :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPJCzx%2Fhomebridge-thermostat%2Fissues%2F52%23issuecomment-624491146&data=02%7C01%7C%7C5d7fe42471cf4920941c08d7f1906b42%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637243474878271147&sdata=2of4S4xZ7j96bQKJ4o867kNPBtzxKKKQzzhAsfteFtg%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH6FFESI2QG6TMGCFOHBFHTRQEHV5ANCNFSM4MZWOTAA&data=02%7C01%7C%7C5d7fe42471cf4920941c08d7f1906b42%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637243474878281140&sdata=1SszI8%2FjkuIM2uteu%2FVm6W%2BKyUfgDOkw18Xhd42Zjio%3D&reserved=0.

PJCzx commented 4 years ago

Hello,

en effet je ne voit pas de référence à ce paramètre y compris dans la doc d’Apple. As-tu quelque chose sous la main ? Au besoin tu peux faire un pull request mais l’idéal est de rester le plus générique possible. Comme je n’ai pas fait des test auto, plus on met du spécifique plus on augment le risque de régressions pour tout le monde.

Tiens moi au courant :)

—-

Indeed I don't see any reference to this parameter even in the Apple doc. Do you have something to share? You can make a pull request if you need it but the best is to stay as generic as possible. As I didn't implemented automatic-tests, the more specific code you put the more you increase the risk of regressions for everyone. Keep me in touch :)

lp4so commented 4 years ago

J’ai utilisé le plugin homebridge-http-thermostat et là le polling fonctionne... Tu peux y jeter un coup d’œil pour voir comment s’est réalisé, parce que je n’ai pas exactement bien capté 😁

Le 24 mai 2020 à 13:26, Pierre-Julien Cazaux notifications@github.com a écrit :



Hello,

en effet je ne voit pas de référence à ce paramètre y compris dans la doc d’Apple. As-tu quelque chose sous la main ? Au besoin tu peux faire un pull request mais l’idéal est de rester le plus générique possible. Comme je n’ai pas fait des test auto, plus on met du spécifique plus on augment le risque de régressions pour tout le monde.

Tiens moi au courant :)

—-

Indeed I don't see any reference to this parameter even in the Apple doc. Do you have something to share? You can make a pull request if you need it but the best is to stay as generic as possible. As I didn't implemented automatic-tests, the more specific code you put the more you increase the risk of regressions for everyone. Keep me in touch :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPJCzx%2Fhomebridge-thermostat%2Fissues%2F52%23issuecomment-633216646&data=02%7C01%7C%7Cd9e90356c7aa4ddb201e08d7ffd548f7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637259163817627155&sdata=EeRJY%2BcUlOBbtiaon%2FCxOAhTHyZPkAwum%2FiAhMDgqJU%3D&reserved=0, or unsubscribehttps://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH6FFEXVPU773W6NFUOX5F3RTD75XANCNFSM4MZWOTAA&data=02%7C01%7C%7Cd9e90356c7aa4ddb201e08d7ffd548f7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637259163817637150&sdata=ApbrDkmfuQI09FNFN7qYKTO%2BUCnDhj3%2FzOzXB78%2BNXg%3D&reserved=0.

lp4so commented 4 years ago

Homebridge-http-thermostat ou Homebridge-web-thermostat, je sais plus 😉

Le 24 mai 2020 à 13:26, Pierre-Julien Cazaux notifications@github.com a écrit :



Hello,

en effet je ne voit pas de référence à ce paramètre y compris dans la doc d’Apple. As-tu quelque chose sous la main ? Au besoin tu peux faire un pull request mais l’idéal est de rester le plus générique possible. Comme je n’ai pas fait des test auto, plus on met du spécifique plus on augment le risque de régressions pour tout le monde.

Tiens moi au courant :)

—-

Indeed I don't see any reference to this parameter even in the Apple doc. Do you have something to share? You can make a pull request if you need it but the best is to stay as generic as possible. As I didn't implemented automatic-tests, the more specific code you put the more you increase the risk of regressions for everyone. Keep me in touch :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPJCzx%2Fhomebridge-thermostat%2Fissues%2F52%23issuecomment-633216646&data=02%7C01%7C%7Cd9e90356c7aa4ddb201e08d7ffd548f7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637259163817627155&sdata=EeRJY%2BcUlOBbtiaon%2FCxOAhTHyZPkAwum%2FiAhMDgqJU%3D&reserved=0, or unsubscribehttps://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH6FFEXVPU773W6NFUOX5F3RTD75XANCNFSM4MZWOTAA&data=02%7C01%7C%7Cd9e90356c7aa4ddb201e08d7ffd548f7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637259163817637150&sdata=ApbrDkmfuQI09FNFN7qYKTO%2BUCnDhj3%2FzOzXB78%2BNXg%3D&reserved=0.