Closed PJK closed 1 year ago
Attention: Patch coverage is 85.71429%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 96.49%. Comparing base (
118f8d3
) to head (b7c04c2
). Report is 271 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
src/cbor/internal/builder_callbacks.c | 85.71% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cc @James-ZHANG
Description
The decoder should clean up intermediate items when the callback fails. The rest of the cleanup is handled by the decoder stack unwinding
Replaces #228. In retrospect, the fix wasn't a good solution: the new behavior did fix the memory leak in the streaming decoder, but the semantics didn't make sense for standalone usage of
cbor_bytestring_add_chunk
and were also inconsistent withcbor_array_push
.Fixes #231
Checklist