PJUllrich / Complete-Bunq-API-Python-Wrapper

Complete Python API Wrapper for Bunq API
MIT License
9 stars 2 forks source link

Multi-inheritance #2

Closed OGKevin closed 7 years ago

OGKevin commented 7 years ago

Found a multi-inheritance error

In the payment endpoint:

class Payment(MonetaryAccount):
      pass

In the request-inquiry endpoint:

class RequestInquiry(MonetaryAccount, Payment):
  pass

Should be:

class RequestInquiry(Payment):
  pass
PJUllrich commented 7 years ago

Thanks, I will fix it with the next commit.

On 15 May 2017, at 16:52, Kevin Hellemun notifications@github.com wrote:

Found a multi-inheritance error

In the payment https://github.com/PJUllrich/Complete-Bunq-API-Python-Wrapper/blob/af5d3c8d2f3e0512c2aee556f1dde75e2e9d710c/endpoints/payment.py#L4 endpoint:

class Payment(MonetaryAccount): pass In the request-inquiry https://github.com/PJUllrich/Complete-Bunq-API-Python-Wrapper/blob/0e28d63c77888f102bd2a4cd9a3610890e1dc70b/apiwrapper/endpoints/request_inquiry.py#L6 endpoint:

class RequestInquiry(MonetaryAccount, Payment): pass Should be:

class RequestInquiry(Payment): pass — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PJUllrich/Complete-Bunq-API-Python-Wrapper/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ8Ym-K6pHJPZwsErLNfeSw7CxUJdLjlks5r6GakgaJpZM4NbPzh.

PJUllrich commented 7 years ago

Fixed in this commit

OGKevin commented 7 years ago

💪