search

PJZ9n / AdvancedForm

Make modern forms easy! You don't have to think about anything.
GNU General Public License v3.0
10 stars 3 forks source link

Add pm5 support #4

Closed Nerahikada closed 1 year ago

Nerahikada commented 1 year ago

PocketMine-MP 5 does not make any BC break changes to Form, and adding the API version to virion.yml seems to be sufficient.

PJZ9n commented 1 year ago

Thank you!

For those planning to use PM5: It's not an API change, but requires updating the network dependent code. https://github.com/PJZ9n/AdvancedForm/blob/94c8c0fed419f5b1d72fe157dec21dcc3326d56b/src/pjz9n/advancedform/chain/FormChainListener.php#L100-L112

Nerahikada commented 1 year ago

InGamePacketHandler::stupid_json_decode seems to have been removed at https://github.com/pmmp/PocketMine-MP/commit/3baa5ab71214f96e6e7ab12cb9beef08118473b5 (whether pm4 or pm5).