search

PKBeam / AMWin-RP

A Discord Rich Presence client for Apple Music's native Windows app.
GNU General Public License v3.0
460 stars 27 forks source link

feat: Send listens to ListenBrainz (#17) #74

Closed SWiegandt closed 8 months ago

SWiegandt commented 8 months ago

Implements sending listens to ListenBrainz in addition to scrobbling to Last.fm. I've never worked with C#/.NET before today, so please feel free to tell me if I've done anything completely stupid.

I had some trouble getting things in the WinForm to line up nicely when changing some of the dimensions due to the ListenBrainz token being longer than the existing fields could accommodate and made some changes to the overall widths and margins to get it working, but if there was any magic in the old way it was structured I can go back and try to make fewer overall changes to it.

I'm also not sure regarding the SemVer used, so if you feel that this is a smaller change than what would constitute a minor version bump just let me know.

I'm also currently saving the user token in the plaintext config file, same as the API key from Last.fm, but would be open to storing it in the credential manager instead.

PKBeam commented 8 months ago

this looks good, I can fix up the UI later.

SWiegandt commented 8 months ago

Once there's a build out and we can see whether there are any regressions introduced I haven't found myself (been using it for a couple of days now and haven't had any issues at least), I could have a look at #22 as well. From what I understand they use essentially the same API as Last.fm, so it could either be very simple or deceptively hard to implement, depending on library flexibility.

PKBeam commented 8 months ago

I've put up a beta build here: https://github.com/PKBeam/AMWin-RP/releases/tag/v1.3.0b1 This also includes some UI automation improvements.