Common C# Coding Conventions

[Nytilde]

I have applied an auto-formatter to use the Common C# Coding Conventions https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/coding-conventions

[PKBeam]

For code styles that are purely preferential (such as braces on new lines) I'd rather we stick to the existing convention of the project - that's generally seen as best practice.

If there are any inconsistencies that this PR clears up I'm happy for those to go through.

[Nytilde]

The topic came up in brolly's last PR. The aim is to consistently adhere to the layout conventions, since we use both notations with the brackets. I also can adjust the automatic conversion of the layout for the other bracket style as well.

[PKBeam]

Since most of the code uses braces on the same line, let's just stick with that then.

[Brollyy]

If we're re-formatting the codebase to adhere to some consistent code styling, I think we should also make sure that there are checks in place to make sure that this sticks and we don't have to redo it every so often - otherwise I see it as a wasted effort.

• To make sure that everyone gets the same outcome when formatting the code and warnings/errors whenever they're not following the style guides, we should introduce .editorconfig file with all the coding styles and enforced rules inside.
• Formatting/Code Cleanup should be automatically run on different levels to reduce the risk of mistakingly introducing inconsistencies again:
  • Run Code Cleanup on Save - this is an option in Visual Studio. Sadly, there's no way to enable it by default on the project, but we could still encourage people to enable it.
  • GitHub Action to validate PR changes - after this PR is merged, I can set it up to run it as a check for pull requests.

[Nytilde]

I hope this should fit. if you have any suggestions for changes, we can add them to the editorconfig as well.