search

PKISharp / ACME-PS

PowerShell module supporting ACME v2 certificate management
MIT License
104 stars 31 forks source link

[BUG] Case sensitivity #94

Closed christoph-bach closed 4 years ago

christoph-bach commented 4 years ago

Hi

This is not a bug rather a change request.

We have an ACME server product which expects case sensitive JSON fields like it is documented in https://tools.ietf.org/html/rfc8555

For example in chapter 7.3 Account Management, we expect the fields "contact" and "termsOfServiceAgreed". Your client sends us these fields with an upper case first letter: "Contact" instead of "contact" and "TermsOfServiceAgreed" instead of "termsOfServiceAgreed".

Expected behavior We would expect that you send case sensitive field names as documented in https://tools.ietf.org/html/rfc8555.

This is not must change but would be good practice because URLs are often case sensitive.

Best regards

glatzert commented 4 years ago

That is a bug.

ALL other functions will be nice and use lowercase except the New-Account function 🤔 I'll fix it and release 1.2.5 within the day.

-- OT -- May I ask what the acme-server is called?

christoph-bach commented 4 years ago

Hi,

Thanks, that is good news. We have implemented ACME in our product true-Xtender Registration Authority (RA-ACME+) and customers are interested in ACME clients implemented in PowerShell.

Link to our product: https://www.keyon.ch/de/Produkte-Loesungen/Microsoft-PKI/index.php#anchor_de2e011d_Accordion-true-Xtender-Registration-Authority

I am therefore testing your client.

Best regards Christoph

glatzert commented 4 years ago

1.2.5 should fix that bug.