First, thanks for this port to ACME v2! I ran into a minor issue when experimenting with the CLI reference implementation. If I choose to use RSA, rather than the default ES, algorithm, the JwsAlg is properly stored as RS256 (hashSize=256, keySize=2048). However, when the state information is restored, in ../src/Examples/ACMECLI/Program.cs:
The current implementation of GenerateTool() resets tool.KeySize, rather than tool.HashSize when RS-style, vs ES-style keytypes are used. I made this change to correct this locally:
First, thanks for this port to ACME v2! I ran into a minor issue when experimenting with the CLI reference implementation. If I choose to use RSA, rather than the default ES, algorithm, the JwsAlg is properly stored as RS256 (hashSize=256, keySize=2048). However, when the state information is restored, in ../src/Examples/ACMECLI/Program.cs:
The current implementation of
GenerateTool()
resetstool.KeySize
, rather thantool.HashSize
when RS-style, vs ES-style keytypes are used. I made this change to correct this locally:I believe the above is the intended behavior. I'll submit a PR with this simple change for you to review and merge if it is acceptable. (See: https://github.com/PKISharp/ACMESharpCore/pull/32)