Exception handling for TOS retrieval

PKISharp / ACMESharpCore

An ACME v2 client library for .NET Standard (Let's Encrypt)

MIT License

325 stars 72 forks source link

Exception handling for TOS retrieval #38

Closed WouterTinus closed 4 years ago

WouterTinus commented 4 years ago

It actually can fail (https://github.com/win-acme/win-acme/issues/1529) and at our level we "don't know" the URL that failed (obviously we could peek at the directory, but it's better handled like this I think.

ebekker commented 4 years ago

Thanks @WouterTinus!

I've merged in the changes, I need to find some time to update the CI/CD configuration, it's failing and I'm sure it's because the build scripts are out of date for AppVeyor.

I've been meaning to switch to using GitHub actions to do the builds and releases, so maybe this will inspire me to find some time.