search

PKISharp / ACMESharpCore

An ACME v2 client library for .NET Standard (Let's Encrypt)
MIT License
325 stars 72 forks source link

New order status #43

Closed WouterTinus closed 4 years ago

WouterTinus commented 4 years ago

Accept HttpStatusCode.OK in response to newOrder request

That's the way Digicert does it, and not forbidden by the RFC

ebekker commented 4 years ago

Interesting, I just compared the final RFC to the draft version that I originally coded against and it seems this part didn't change -- the language still seems to imply that a 201 Created response is what is supposed to be issued:

   If the server is willing to issue the requested certificate, it
   responds with a 201 (Created) response.  The body of this response is
   an order object reflecting the client's request and any
   authorizations the client must complete before the certificate will
   be issued.

But I guess every vendor has the right to interpret a standard as they see fit :-)

As always, thanks for the PR!

WouterTinus commented 4 years ago

The RFC is pretty clear yes, 201 is mentioned in several places. Never with a MUST attached to it though. It's verrryy fishy but it seems like certbot (which they all test against) doesn't make a fuss about it, so why should we 😄. Thanks for the merge!