Cannot specify certificate validity period

PKISharp / ACMESharpCore

An ACME v2 client library for .NET Standard (Let's Encrypt)

MIT License

325 stars 72 forks source link

Cannot specify certificate validity period #45

Closed campler closed 4 years ago

campler commented 4 years ago

In AcmeProtocolClient, we can clearly see that code to handle validity period has been commented out ~2 years ago. I could not find an explanation for this in commit history.

However, I would like to use this library with a different CA with our own variable validity periods. I was wondering if there are any plans to make this functional?

ebekker commented 4 years ago

You're absolutely right, looks like a TODO that I had left over and never got around to finishing. Unfortunately LE does not honor any requests for a validity period since it always issues 90-day certificates no matter what, so I won't be able to test this change.

ebekker commented 4 years ago

Would you mind pulling down and testing this early access build and testing it out for your scenario? If you can confirm this addresses your use case, I can promote it as a stable release.

campler commented 4 years ago

I have tested the build and it is working as expected.

Thanks again