Expose identifier class directly in the CreateOrderAsync method

PKISharp / ACMESharpCore

An ACME v2 client library for .NET Standard (Let's Encrypt)

MIT License

325 stars 72 forks source link

Expose identifier class directly in the CreateOrderAsync method #49

Closed Maximebb closed 4 years ago

Maximebb commented 4 years ago

As a means of supporting other types of identifiers for acme orders (e.g. https://tools.ietf.org/html/draft-ietf-acme-ip-05), the method for creating an order was overloaded to exposes an IEnumerable of Identifiers. The original method signature was kept and uses the generic version. This will allow a caller to chose it's identifier type and still keep the old dns-only behavior.

Maximebb commented 4 years ago

I didn't see any particular unit tests where changes were necessary (or needed to be added). Let me know if I missed something.

Maximebb commented 4 years ago

fixes #46

Maximebb commented 4 years ago

The build not passing doesn't seem related to my changes, is it?

ebekker commented 4 years ago

Looks good, thank you for the contribution!

Sorry it took so long -- the CI build was broken and I decided to move it to GitHub Workflows which took a little time to get right.