PKISolutions / Asn1Editor.WPF

Graphical WPF-based Abstract Syntax Notation One (ASN.1) DER editor
Microsoft Public License
193 stars 61 forks source link

Allow font sizes bigger than 16 #33

Open ralienpp opened 11 months ago

ralienpp commented 11 months ago

I would be happier if the software allowed me to type in a custom font size, rather than limit me to a choice among the predefined options. Currently 16 is the maximum, but it would be even more comfortable for my eyes if I could go beyond that.

Crypt32 commented 11 months ago

I limited this to 16 because larger fonts may cause unfortunate side effects on smaller displays due to panel auto-resizing. Hex viewer and converter dialog auto-size to fit content without horizontal scrollbar and text wrapping. In addition, node icons are not in vector format, they are plain PNGs and won't resize. You may end up with this weird look: image

There is a need to work on font sized in other places, such as menus, tab headers, etc. In other words, current font implementation is quite imperfect at large scales.

ralienpp commented 11 months ago

I can redraw the icons as SVG - would that help? Alternatively, what format would you prefer to have it in?

As for the first point - I think it makes sense to allow larger fonts, because users with smaller screens will leave this option at a value that makes sense to them.

Crypt32 commented 11 months ago

I can redraw the icons as SVG - would that help?

I guess it will. Maybe as a test, you could make just a couple of icons so I can test how they will fit.

Alternatively, what format would you prefer to have it in?

XAML drawing. Raw SVG isn't natively supported, but I can use XAML drawing from SVG.

ralienpp commented 11 months ago

Let's try some quick prototyping with Tango icons that are freely available. https://commons.wikimedia.org/wiki/Tango_icons

For example, i for the OID icon could be https://commons.wikimedia.org/wiki/Tango_icons#/media/File:Tango-style_info_icon.svg

If this gives satisfying results in principle, then we can tweak the icons to make them more appropriate (e.g., remove the shadows, simplify the design to make it more fitting for small sizes).

Crypt32 commented 11 months ago

Sounds like a good starter, I will try them. Will not promise anything on timelines though.

Crypt32 commented 11 months ago

I gave it a try and here is how it looks for OID tag: image This particular example is imperfect, however I can use converted SVGs to render them as images.