PKM-er / media-extended

enhanced media(video/audio) playback for obsidian.md
https://mx.pkmer.net
MIT License
643 stars 55 forks source link

Incredibly long advertisements interrupt media player #340

Open notuntoward opened 7 months ago

notuntoward commented 7 months ago

In the middle of a lecture I'm watching, there are minutes-long advertisement interruptions. Is this an attempt to get revenue for this plugin? If so, it destroys its usefulness.

aidenlx commented 7 months ago

Why would I ever get revenue from a random YouTube video😂 the plugin comes with a simple adblocker that may not always work, if you have a YouTube Premium account, you can login from settings.

notuntoward commented 7 months ago

There aren't any advertisements in this video if I watch it directly on YouTube (no ad blockers running). It's coming from the U. of California (CalTech), and they don't do ads. It's not related to having or not having a YouTube Premium account.

aidenlx commented 7 months ago

First, I want to assure you that there is no intention to generate revenue by inserting ads through the plugin. It's completely open-source, and you're free to check the code to verify this.

Regarding the ads you're seeing, it's important to note that YouTube might include ads based on several factors, even if the publisher hasn't joined the YouTube Partner Program. This can happen in various scenarios, such as when content is embedded from YouTube into other applications or viewed under different regional settings. For more clarity on this, Google’s support pages (mid-roll ad breaks, Ad placement policies and How ads are targeted to your videos) provide detailed insights into how ads may appear based on the environment rather than the content creator’s choice.

Additionally, the plugin includes a basic ad blocker, but it might not catch everything, especially with how dynamic YouTube's ad-serving algorithms can be. If you can provide more details about the issue, such as specific instances when the ads appeared or logs, it would greatly help in improving the ad-blocking feature.

notuntoward commented 7 months ago

Thanks for the response.

Here's an example video, and here's a snapshot of the advert that played, just now, when I started the media player: image

Earlier, it was also interrupted in the middle, after I paused/played it. Also, sometimes, there were flickers, like an advert ran for 250 ms or something, and then got shut off.

This is all on Windows and Obsidian 1.5.12.

I wonder what Timestamp Notes does, as I don't remember ever seeing advertising in its media window.

aidenlx commented 7 months ago

By default the video is running in a standard website for better compatibility and subtitle support. If you want ad-free experience similar to timestamp note, just right-click on any YouTube link and select iframe option in always open as.

notuntoward commented 7 months ago

Thanks! This option solves the advert problem.

One other option that would be nice to have is one that makes it possible to open video links in the default browser, so that the only time the media viewer is turned on is when I run a specific command.

aidenlx commented 7 months ago

One other option that would be nice to have is one that makes it possible to open video links in the default browser, so that the only time the media viewer is turned on is when I run a specific command.

It would be nice to open a separate issue to help keeping track of the request :)

aidenlx commented 6 months ago

could you try latest 3.2.3 improve ad skipping?

fnaufel commented 6 months ago

By default the video is running in a standard website for better compatibility and subtitle support. If you want ad-free experience similar to timestamp note, just right-click on any YouTube link and select iframe option in always open as.

Thanks for the great plugin.

When I open a YouTube video as iframe and try to take a snapshot, the plugin says it is not possible to take snapshots for this type of media.

If I open the same video as webpage, the plugin lets me take snapshots.

I'm running Media Extended 3.2.4.

orvpagadua commented 5 months ago

is there a feature to skip ads just like in youtube?

notuntoward commented 5 months ago

could you try latest 3.2.3 improve ad skipping?

No ads showed up on the first few videos I tried, but then I got the ad below after clicking on this video link.

image