PKM-er / obsidian-editing-toolbar

An obsidian toolbar plugin, modified from the Cmenu plugin
Mozilla Public License 2.0
867 stars 31 forks source link

using editor bar on mobile keeps closing keyboard #143

Open kulizivo opened 7 months ago

kulizivo commented 7 months ago

Basically, every time I try to use the toolbar it ends up closing the keyboard on everything except the highlighter. This means every other command will end up closing the keyboard and only leaving the toolbar active.

codey-badger commented 3 months ago

Are u still having this issue? If yes don't forget to leave the devices info ^^

kulizivo commented 3 months ago

@codey-badger Yes Android 13 Redmi note 10Pro 128 - 6ram Minimal theme

ChasKane commented 3 months ago

same, although the toolbar does seem to bring the keyboard back up after a half second or so.

I ran into this seemingly unavoidable issue when trying to develop my own toolbar -- it seems that all clicks/taps on anything other than text, even buttons inserted into the markdown, cause the keyboard to disappear. @codey-badger do you think the keyboard reappearing behavior new since last week? I'm wondering if you've looked at this and concluded that's the best that can be done given Obsidian's closed source.

codey-badger commented 3 months ago

@ChasKane yeah it's quite unfortunate and annoying tbh. Today tested the plugin and sometimes the toolbar itself disappears from top or has the erratic behavior with the keyboard.

As a heavy mobile user, my unsolicited advice is:

  1. Sticking to the core plugins and functions as much as possible (I use Slash commands extensively).
  2. Refining the workflow using the command configure mobile toolbar and Hotkeys (option in settings).

For more functionality you could try Note Toolbar Plugin and see how it goes. Although I'm comfortable with the core mobile toolbar + Commander Plugin + QuickAdd Plugin here and there.

Another recommendation I'm currently testing is Text format plugin.

Finally Settings Search Plugin to make customization easier.

Hope that helps!

kulizivo commented 3 months ago

@ChasKane & @codey-badger try popkit on mobile

ChasKane commented 3 months ago

o.0 ahhhhh @kulizivo is your account ok? popkit looks like spam.

ChasKane commented 3 months ago

@codey-badger configure mobile toolbar is a gem and so is the reminder about slash commands, thank you! Otherwise, l think we're in the same boat. I have a dream of a colorful, dynamic, animation-ladened toolbar with similar features to this plugin but a smoother UI and better customization potential, but with Obsidian being as opaque as it is, I have to relent that my energy is better spent elsewhere.

kulizivo commented 3 months ago

@ChasKane really? this plugin Popkit?

ChasKane commented 3 months ago

@kulizivo oh I love this plugin, but I can't get the commands to drag properly in the settings pane. Are you having this issue too?

kulizivo commented 3 months ago

@ChasKane yes its really bad on mobile but on desktop it works much better

ChasKane commented 2 months ago

@codey-badger the erratic behavior we discussed seems to be addressed by adding event.preventDefault() to both the click and mousedown event listeners set on each command button. I'll have a prototype of my own toolbar up soon

onClick={(e) => {
  global.app.commands.executeCommandById(command.id);
  e.preventDefault();
}}
onMouseDown={(e) => e.preventDefault()}
kulizivo commented 2 months ago

@ChasKane thanks for the edit. tell me when your version of the toolbar is up... ill be happy to test drive it for you

ChasKane commented 1 month ago

@kulizivo it's looking p good. drag and drop buttons, customize commands, colors, etc. It feels really good to use, even if it's a hair buggy. I'm still working on it but if you wanna give it a shot, git clone the repo into your plugins folder, run npm run dev to compile the typescript to main.js, and have a blast ^.^

https://github.com/ChasKane/gay-toolbar

kulizivo commented 1 month ago

@ChasKane hey i checked this https://github.com/ChasKane/gay-toolbar out, interesting name. But in terms of use custmization its really good. buttons work just fine and it definitely works a dream... though it is still a little buggy and and should have adjustments not to appear on pc if the user only wants it mobile... outside of that amazing plugin... by the way as just a suggestion, you could also make it possible to use an aimage for the background and also add transparency sliders for the buttons as well

ChasKane commented 1 month ago

So glad you like it! I already have both the desktop/mobile issue and the button transparency issue on my list. As for backgrounds, I think in the latest versions you can do that with theCustom Css option. lmk how that goes.

I'm working on a bug rn that's causing the text cursor to go under the toolbar. v annoying. but the solution seems to have simplified the plugin immensely. I'll keep you posted ^.^

EDIT: bug fixed in latest commit to main!

ChasKane commented 1 month ago

For desktop/mobile, I think I'll leave it up to users to disable it on desktop and not on mobile via the Sync feature (you can sync the plugins list but not the list of which ones of that list are active). What do you think?

kulizivo commented 4 weeks ago

well its okay if that's the only option but in my case I use third party syncing so ill have to look for a work around

ChasKane commented 3 weeks ago

Lmk what you find. I might be able to implement it in the next update. I'll have to experiment with loading the settings synchronously before render -- if that works, I can just disable the plugin if a "use on desktop" setting is off. I'll keep you posted.

ChasKane commented 3 weeks ago

@kulizivo I added the mobile-only feature, will be available in the second release

kulizivo commented 3 weeks ago

okay update me when you release it since i try out the app on a separate device