search

PKM-er / obsidian-editing-toolbar

An obsidian toolbar plugin, modified from the Cmenu plugin
Mozilla Public License 2.0
848 stars 30 forks source link

Inconsistent cursor type for the "following" and "fixed" position #144

Closed s4my closed 6 months ago

s4my commented 6 months ago

Describe the bug When the position is set to "following" or "fixed", some buttons have the "default" cursor type, others the "pointer" type.

Solution I don't think we should use the "pointer" type; Obsidian doesn't use it anywhere on any of its buttons. To respect the Obsidian design system, I think we shouldn't either, plus the "pointer" cursor is usually only used on web applications.

I am willing to submit a PR to fix this issue if you're OK with my proposition.

cumany commented 6 months ago

Thank you for pointing out this issue. The new version has been fixed. I'm not sure if the fix meets your expectations. Also, welcome to submit a pull request anytime.

s4my commented 6 months ago

Sure, but you introduced a bad styling for the hover style of the buttons. I think you're using a custom theme or something that is distorting your testing. This is how the hover style looks on default theme:

et

Sub-items have a different style too. I fixed the issue with the PR #147