refactor: refactored the positioning system of the toolbar in the "following".

PKM-er / obsidian-editing-toolbar

An obsidian toolbar plugin, modified from the Cmenu plugin

Mozilla Public License 2.0

824 stars 29 forks source link

refactor: refactored the positioning system of the toolbar in the "following". #150

Closed s4my closed 5 months ago

s4my commented 5 months ago

Refactor the way the toolbar's position is calculated for the "following" mode to make sure the toolbar:
- Is always visible, even when we the user selects the last or first line in the editor. (which was not the case before this commit)
- To try not to overflow over the File Explorer or the Outline.
Refactord isExistoolbar() to get rid of deprecated code (i.e., activeLeaf), and to simplify the code.
Refactored getModestate() into isSource(): since getModestate() doesn't really get the mode state, but rather returns whether the MarkdownView mode state is "source" or not, I renamed it to isSource() to reflect just that, and simplified the function implementation in the process.

cumany commented 5 months ago

Thank you for your work. There seems to be a positioning issue with my computer; the toolbar keeps overflowing off the screen. We'll hold off on merging branches until it's resolved. More improvements to come.

s4my commented 5 months ago

the toolbar keeps overflowing off the screen.

Can you elaborate more please, what do you mean off screen? like outside of Obsidian's window completely? and can you please make sure to disable any plugins or themes that might interfere with your testing (you could use Obsidian sandbox vault). I updated the code, please try again and keep me updated.

cumany commented 5 months ago

it looks a bit more normal, but the following list of tests will help you to determine if you have the same problem:

Multiple rows are selected from left to right and the toolbar is obscuring the center.
selecting words at the end of a line from left to right completely obscures the words.
This problem seems to be a little more pressing, as in workplace panel with a left/right split screen, when you select text on the right side of the split screen, the toolbar is still in the same place as on the left side of the split screen.

s4my commented 5 months ago

Hi @cumany, thank you for the detailed feedback, I fixed all the issues you mentioned above in this new commit. If you need me to make any further changes feel free to tell.

cumany commented 5 months ago

Good job. It was perfect!