PKM-er / obsidian-zotlit

A third-party project that aims to facilitate the integration between Obsidian.md and Zotero, by providing a set of community plugins for both Obsidian and Zotero.
https://zotlit.aidenlx.top
MIT License
589 stars 25 forks source link

Not escaped / in filename for the ability to specify directories #296

Open theotheo opened 6 months ago

theotheo commented 6 months ago

Hello! I'm trying to sync Zotero and Obsidian, so I decided to give your project a try. Thanks for developing it!

However, personally, I found the lack of the ability to create directories according to a template. Issue #207 showed that I'm not alone in this. Code exploration suggested that this could be achieved with minimal changes. So, I decided to create this pull request (PR).

P.S.

I had never dealt with rushjs before. So, in the end, exploring and modifying the code took 10 minutes, but the build took 2 and a half hours for some reason! It seemed like I was missing some packages. I don't know how much value my observations on this matter hold for you. But for example, I had to do this:

rush add -p esbuild-sass-plugin
rush add -p @preact/signals-core

And something wrong with ophidian-lib-core submodule.

At the end I was not able to run the production build as well, but I'm currently using the development build.

P.P.S.

Yes, I saw that you mentioned it's not simple and that's indeed true :)