Closed mhasel closed 1 month ago
Attention: Patch coverage is 0%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 95.63%. Comparing base (
dafaa7e
) to head (9c4eb39
).
Files | Patch % | Lines |
---|---|---|
compiler/plc_driver/src/main.rs | 0.00% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
When the compilation ends with a diagnostic with severity
Error
, we now no longer exit with0
(Success) but rather1
(Catchall for general errors, as defined in the Linux Documentation Project). I've also looked at the BSD standards (mirrored in the exitcode crate) and, if we want to follow these guidelines, we could opt to change it to65 - Data Error
, but I would suggest to stick with1
for now until we decide on a more fine-grained exit approach for different error scenarios.Refs: #817