PLC-lang / rusty

Structured Text Parser and LLVM Frontend
GNU Lesser General Public License v3.0
183 stars 48 forks source link

Add linker for MacOS Ventura (13.0.1) #702

Closed volsa closed 1 year ago

volsa commented 1 year ago

Also do we want to remove this hardcoded line or should we leave it for now? https://github.com/PLC-lang/rusty/blob/be867c637f9db54289082e516b9c53ddaf64ed04/src/linker.rs#L182-L184

ghaith commented 1 year ago

Also do we want to remove this hardcoded line or should we leave it for now?

https://github.com/PLC-lang/rusty/blob/be867c637f9db54289082e516b9c53ddaf64ed04/src/linker.rs#L182-L184

Yes we should not need this anymore i think

codecov-commenter commented 1 year ago

Codecov Report

Base: 94.41% // Head: 94.43% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (4d59efd) compared to base (be867c6). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #702 +/- ## ========================================== + Coverage 94.41% 94.43% +0.01% ========================================== Files 46 46 Lines 16228 16232 +4 ========================================== + Hits 15321 15328 +7 + Misses 907 904 -3 ``` | [Impacted Files](https://codecov.io/gh/PLC-lang/rusty/pull/702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PLC-lang) | Coverage Δ | | |---|---|---| | [src/linker.rs](https://codecov.io/gh/PLC-lang/rusty/pull/702/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PLC-lang#diff-c3JjL2xpbmtlci5ycw==) | `81.69% <100.00%> (+2.50%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PLC-lang). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PLC-lang)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

volsa commented 1 year ago

@ghaith would you be OK with the current solution, ignoring that one specific test for now? I'll see if I can fix this test in the coming days but merging this would be awesome because I could work on my MacBook without any local patching shenanigans :P

ghaith commented 1 year ago

Yes finde by me