Closed volsa closed 1 year ago
Also do we want to remove this hardcoded line or should we leave it for now?
Yes we should not need this anymore i think
Base: 94.41% // Head: 94.43% // Increases project coverage by +0.01%
:tada:
Coverage data is based on head (
4d59efd
) compared to base (be867c6
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@ghaith would you be OK with the current solution, ignoring that one specific test for now? I'll see if I can fix this test in the coming days but merging this would be awesome because I could work on my MacBook without any local patching shenanigans :P
Yes finde by me
Also do we want to remove this hardcoded line or should we leave it for now? https://github.com/PLC-lang/rusty/blob/be867c637f9db54289082e516b9c53ddaf64ed04/src/linker.rs#L182-L184