search

PLCHome / node-red-contrib-ads

Beckhoff TwinCat ADS support for Node-Red.
MIT License
15 stars 11 forks source link

Use of Topic in ADS notification node #7

Closed vdwpsmt closed 5 years ago

vdwpsmt commented 5 years ago

feature request It would be nice if there is an option to define the topic for an ads notification node.
In the current situation you receive a message with just a value, so with no relation to which variable this value belongs to. If input field Topic is left blank the name of the variable could be used by default.

PLCHome commented 5 years ago

Yes i can do that. At the moment you can set only an property name: msg.payload.PropertyName = value

I have a look in the next two weeks

PLCHome commented 5 years ago

Topic added on all nodes

PLCHome commented 5 years ago

is that what you need? Or did I misunderstand the request?

vdwpsmt commented 5 years ago

Perfect like that!. Ideal for logging etc... Thanks for the fast response! This ads-node is a very helpfull tool for easy accessing twincat plc's!

Van: "ChrisHanuta" notifications@github.com Aan: "ChrisHanuta/node-red-contrib-ads" node-red-contrib-ads@noreply.github.com Cc: "pascal" pascal.desmet@telenet.be, "Author" author@noreply.github.com Verzonden: Vrijdag 19 oktober 2018 16:14:07 Onderwerp: Re: [ChrisHanuta/node-red-contrib-ads] Use of Topic in ADS notification node (#7)

is that what you need? Or did I misunderstand the request?

— You are receiving this because you authored the thread. Reply to this email directly, [ https://github.com/ChrisHanuta/node-red-contrib-ads/issues/7#issuecomment-431377461 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/An-_xg6g4grzwCQiPAoXiGXqm8BKZJg4ks5umd4vgaJpZM4XjRXP | mute the thread ] .

martinschki commented 5 years ago

should this work in 1.1.14? I'm installing through node red palette manager and 1.1.14 is what I get In the msg object I only find the payload, no topics...

(This node is exactly what I was looking for...Thanks a lot!!)

PLCHome commented 5 years ago

It works for me. Which node did you try? Did you enter the topic, otherwise the tropic will not be send.

martinschki commented 5 years ago

oh, i thought its sending the variable name if topic is kept empty!

PLCHome commented 5 years ago

oh sorry, it does not work that way.

martinschki commented 5 years ago

Sorry, I assumed since it was in the original ticket at the top no worries! great node!!

vdwpsmt commented 4 years ago

hey,

I noticed that using the topic in the symbols node doesn't seem to work similar like the ads in node. on the ads-in node, if you set msg.config.topic this value will be transferred to msg.topic at the output of the node. For symbols that doesn't seem to work.