PLN-team / PLNmodels

A collection of Poisson lognormal models for multivariate count data analysis
https://pln-team.github.io/PLNmodels
GNU General Public License v3.0
54 stars 18 forks source link

114 inconsistency between fitted and predict #115

Closed mahendra-mariadassou closed 10 months ago

mahendra-mariadassou commented 10 months ago

Fix #114 by changing behavior of predict() method (and corresponding S3-methods) for PLNfit objects:

Open question for @jchiquet : should we return $M_{new}$ and $S_{new}$ as attributes of the predictions (like we do for predict_cond() ? I think there's not a lot of added value compared to using optimize_vestep() if one is mostly interested in M and S but you may have a different opinion.

jchiquet commented 10 months ago

Open question for @jchiquet : should we return and as attributes of the predictions (like we do for predict_cond() ? I think there's not a lot of added value compared to using optimize_vestep() if one is mostly interested in M and S but you may have a different opinion.

I agree with you, no need to send back M or S as attributes.