PLSysSec / cargo-scan

A tool for auditing Rust crates
MIT License
15 stars 3 forks source link

UX improvements #47

Closed cdstanford closed 1 year ago

cdstanford commented 1 year ago

From discussion today,

Currently the -r flag is supposed to do the third thing, but I can't quite get it to do what I want. Maybe the solution is just, if the audit file doesn't exist, create it with the default scan?

caleb@caleb-mac cargo-scan % cargo run --bin audit data/test-packages/fns-closures audit.audit2 -r
    Finished dev [unoptimized + debuginfo] target(s) in 0.40s
     Running `target/debug/audit data/test-packages/fns-closures audit.audit2 -r`
Error: Audit file to review doesn't exist
caleb@caleb-mac cargo-scan % 
caleb@caleb-mac cargo-scan % 
caleb@caleb-mac cargo-scan % cargo run --bin audit data/test-packages/fns-closures audit.audit3 -r
    Finished dev [unoptimized + debuginfo] target(s) in 0.53s
     Running `target/debug/audit data/test-packages/fns-closures audit.audit3 -r`
Error: Audit file to review doesn't exist
DavidThien commented 1 year ago

Finished with this pending a decision on if we need to have a better output format for the preview behavior (list all effects and don't save to an audit file).

cdstanford commented 1 year ago

woohoo