PLVision / SAI-Challenger.OCP

Other
0 stars 0 forks source link

No function which starts capturing on one or few ports (but not all ports) #24

Open ivan-kovtun-plv opened 1 year ago

ivan-kovtun-plv commented 1 year ago

The project has a start_capture(self) from class SaiDataplaneImpl as a function starting capturing. Now this method starts capturing on all ports and it doesn't have possibility to choose only one port to start capturing. However when there is a tool which stops capturing on one port automatically after getting buffer from this port, it can cause some bugs. Using start_capture() for restarting capturing automatically stopped causes restarting capturing on all other ports and loosing their buffer content. So, it is needed to add possibility to start capturing on one port without. A solution can be a refactoring start_capture(self) from class SaiDataplaneImpl An alternative solution is to add a new function.

anton7811 commented 1 year ago

Examples: https://github.com/open-traffic-generator/conformance/blob/main/features/flows/headers/udp/test_udp_header.py#L42

https://github.com/open-traffic-generator/conformance/blob/main/features/flows/headers/udp/test_udp_header.py#L49