PLhery / node-twitter-api-v2

Strongly typed, full-featured, light, versatile yet powerful Twitter API v1.1 and v2 client for Node.js.
https://www.npmjs.com/package/twitter-api-v2
Apache License 2.0
1.29k stars 176 forks source link

TweetV1 missing some properties #403

Open HRK44 opened 1 year ago

HRK44 commented 1 year ago

On the TweetV1 interface I don't see extended_tweet. When I console log what I'm receiving from the stream v1 api, I get this field in the tweet :

{...
  coordinates: null,
  place: null,
  contributors: null,
  is_quote_status: false,
  extended_tweet: {
    full_text: 'It’s always been about quality over quantity for us. We truly do have some special holders and we appreciate you all 💜 https://t.co/xDnKMxLRCl',
    display_text_range: [ 0, 118 ],
    entities: {
      hashtags: [],
      urls: [],
      user_mentions: [],
      symbols: [],
      media: [Array]
    },
    extended_entities: { media: [Array] }
  },
  quote_count: 0,
  reply_count: 0,
  retweet_count: 0,
...}

which doesn't show in the TweetV1 interface.

PLhery commented 1 year ago

Hello,

This field is not officially documented in the Tweet object documentation https://developer.twitter.com/en/docs/twitter-api/v1/data-dictionary/object-model/tweet

It looks like it used to be useful when tweets went from 140 to 280 char, to show the 280char version. https://developer.twitter.com/en/docs/twitter-api/premium/data-dictionary/overview

Now it's not useful anymore and we should discourage users to leverage it as it is not officially documented and could be removed.

I don't think we should add it to the library (what do you think @alkihis)

alkihis commented 1 year ago

Hi @PLhery, v1 API have a uncommon pattern on some non-classic endpoints (stream/ads API) where this prop can be available. I need to check this by myself first, but we can think of making a dedicated interface for v1 streamed tweets if necessary?

alkihis commented 1 year ago

Hello, Can you identify the props to modify and make a PR for this?