search

PLhery / node-twitter-api-v2

Strongly typed, full-featured, light, versatile yet powerful Twitter API v1.1 and v2 client for Node.js.
https://www.npmjs.com/package/twitter-api-v2
Apache License 2.0
1.32k stars 186 forks source link

Added returnFullMediaData parameter to v1 uploadMedia #509

Closed yangpten closed 10 months ago

yangpten commented 11 months ago

Adding a returnFullMediaData parameter per: https://github.com/PLhery/node-twitter-api-v2/issues/506

PLhery commented 10 months ago

Hello, I'm sorry I didn't reply earlier, I was traveling for the holidays.

Awesome thank you, any reason why you also added this "prepare" script?

yangpten commented 10 months ago

Hello, I'm sorry I didn't reply earlier, I was traveling for the holidays.

Awesome thank you, any reason why you also added this "prepare" script?

Hi it's to ensure that the build script is executed by npm install so that the dist is always up to date.

PLhery commented 10 months ago

Sure, it could be handy but I think it depends on everyone's tastes and I'm not sure how it would affect the current github automated workflow (and caching mechanisms), so let's skip this change.

I'll remove it and merge the changes later tonight, thank you for proposing this CL!

PLhery commented 10 months ago

Thank you, feature available in v1.16.0 (I slightly added doc and better typings here https://github.com/PLhery/node-twitter-api-v2/commit/414ba71fb4bae6f3e9c0f746a21a0c11b868372e)