PLhery / node-twitter-api-v2

Strongly typed, full-featured, light, versatile yet powerful Twitter API v1.1 and v2 client for Node.js.
https://www.npmjs.com/package/twitter-api-v2
Apache License 2.0
1.31k stars 186 forks source link

add dm_conversation_id to TDMEventV2Field #547

Closed RenKoya1 closed 2 weeks ago

RenKoya1 commented 1 month ago

https://developer.x.com/en/docs/x-api/direct-messages/lookup/api-reference/get-dm_events

PLhery commented 1 month ago

Thank you! Actually the rest of the fields seem wrong, maybe you could try to fix that too?

RenKoya1 commented 1 month ago

Okay!

PLhery commented 3 weeks ago

Hello,

I believed you added "texts" to BaseDMEventV2, but I don't think "ParticipantsJoin" events have text

What I meant is that the other TDMEventV2Field accepted strings seemed wrong to me, maybe I'm wrong

RenKoya1 commented 2 weeks ago

Hello,

I believed you added "texts" to BaseDMEventV2, but I don't think "ParticipantsJoin" events have text

What I meant is that the other TDMEventV2Field accepted strings seemed wrong to me, maybe I'm wrong

My bad. I fixed it

PLhery commented 2 weeks ago

thank you! (id, name, event type are missing too, I'll add them myself)

PLhery commented 2 weeks ago

Published in 1.18.2