search

PMACS / scenic_oracle_enhanced_adapter

OracleEnhanced adapter for Scenic gem.
MIT License
5 stars 2 forks source link

Add no_data param to MV methods so they match up with Scenic #19

Closed brianthoman closed 4 years ago

brianthoman commented 4 years ago

Fixes #18

Hey everyone, My team keeps monkey-patching this in our projects, and Tim rightly suggested that maybe it was time we just submit a PR, so here it is.

I took the discussion on the issue into account and set BUILD DEFERRED based on the no_data argument in case anyone needs that. I think I'm going to submit an issue to Scenic in the hopes that they'll open up ways to pass other options to the adapters though, since Oracle materialized views have lots of other options that we can't currently add through Scenic.