PMCC-BioinformaticsCore / janis-core

Core python modules for Janis Pipeline workflow assistant
GNU General Public License v3.0
4 stars 9 forks source link

Fix for no memory + memory expression #101

Closed illusional closed 3 years ago

illusional commented 3 years ago

Supersedes #98.

mr-c commented 3 years ago

Thanks! While I don't need the credit personally, it would be nice for other contributors if you had either pushed to my branch (if you are a maintainer) or used my commits in your branch, or stuck a Co-authored-by: Michael R. Crusoe <michael.crusoe@gmail.com> as the last line of the relevant commits. https://docs.github.com/en/github/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

illusional commented 3 years ago

Sorry @mr-c, I had intended to do that (like the other PR). Woah, that coauthor commit is magic, I didn't know you could attribute commits like that! I'll definitely be using that in the future.