search

PMCC-BioinformaticsCore / janis-core

Core python modules for Janis Pipeline workflow assistant
GNU General Public License v3.0
4 stars 9 forks source link

Attempt to add Bash / Shell translation #28

Open illusional opened 4 years ago

illusional commented 4 years ago

Currently only works for command tools

Relates to:

codecov-commenter commented 4 years ago

Codecov Report

Merging #28 into master will increase coverage by 0.13%. The diff coverage is 64.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   52.75%   52.88%   +0.13%     
==========================================
  Files          60       62       +2     
  Lines       10496    10617     +121     
==========================================
+ Hits         5537     5615      +78     
- Misses       4959     5002      +43
Impacted Files Coverage Δ
...anis_core/translationdeps/supportedtranslations.py 81.81% <20.00%> (-12.63%) :arrow_down:
janis_core/translations/bash.py 63.96% <63.96%> (ø)
janis_core/tests/test_translation_bash.py 100.00% <100.00%> (ø)
janis_core/tool/tool.py 70.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 976f1a3...a1ca9dc. Read the comment docs.

mr-c commented 3 years ago

Cool! We looked into doing this for CWL, but I'm happy to see it happen here instead