PMCC-BioinformaticsCore / janis-core

Core python modules for Janis Pipeline workflow assistant
GNU General Public License v3.0
4 stars 9 forks source link

Upgrade to CWL v1.2 #40

Closed illusional closed 4 years ago

illusional commented 4 years ago

With conditionals being released, it's time to upgrade Janis workflows to CWL v1.2. This shouldn't be a breaking change for workflows as there's no syntax change. It might break your engine if your engine doesn't correctly support CWL v1.2 - so it might be worth bumping Janis to v0.11.x.

codecov-commenter commented 4 years ago

Codecov Report

Merging #40 into master will increase coverage by 0.12%. The diff coverage is 84.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   74.44%   74.57%   +0.12%     
==========================================
  Files          67       67              
  Lines        8206     8247      +41     
==========================================
+ Hits         6109     6150      +41     
  Misses       2097     2097              
Impacted Files Coverage Δ
janis_core/translations/cwl.py 77.04% <78.94%> (+0.18%) :arrow_up:
janis_core/tests/test_translation_cwl.py 100.00% <100.00%> (ø)
janis_core/types/common_data_types.py 60.84% <100.00%> (ø)
janis_core/types/data_types.py 80.22% <100.00%> (ø)
janis_core/workflow/workflow.py 47.92% <0.00%> (+0.95%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bba3eb5...0cb2efe. Read the comment docs.

codecov-io commented 4 years ago

Codecov Report

Merging #40 into master will increase coverage by 0.12%. The diff coverage is 87.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   74.32%   74.44%   +0.12%     
==========================================
  Files          67       68       +1     
  Lines        8389     8430      +41     
==========================================
+ Hits         6235     6276      +41     
  Misses       2154     2154              
Impacted Files Coverage Δ
janis_core/translations/cwl.py 75.70% <78.94%> (+0.25%) :arrow_up:
janis_core/deps/__init__.py 100.00% <100.00%> (ø)
janis_core/tests/test_translation_cwl.py 100.00% <100.00%> (ø)
janis_core/tests/test_translation_wdl.py 98.47% <100.00%> (ø)
janis_core/tool/commandtool.py 70.26% <100.00%> (ø)
janis_core/translations/wdl.py 83.37% <100.00%> (ø)
janis_core/types/common_data_types.py 61.68% <100.00%> (-0.15%) :arrow_down:
janis_core/types/data_types.py 80.11% <100.00%> (-0.12%) :arrow_down:
janis_core/workflow/workflow.py 49.38% <0.00%> (+0.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0eda4b...dc380a6. Read the comment docs.