PMCC-BioinformaticsCore / janis-core

Core python modules for Janis Pipeline workflow assistant
GNU General Public License v3.0
4 stars 9 forks source link

Fasta File suffixes #47

Closed drtconway closed 3 years ago

drtconway commented 3 years ago

Hi Janis,

I'm getting the following warning:

2020-11-12T15:19:18 [WARN]: The input for 'fasta' (FastaFai) did not have the expected extension .fasta OR .fa: /data/reference/dawson_labs/genomes/GRCh38/GCA_000001405.15_GRCh38_full_analysis_set.fna.

An extension of .fna is pretty wide-spread for FASTA files, and is in some sense even preferable to .fa or .fasta since it specifically suggests it contains nucleotides (i.e. DNA or RNA) rather than, for example .faa which is used to contain amino acids, also in the FASTA format.

It'd be polite of Janis not to produce a warning in this case.

Thanks Tom.

illusional commented 3 years ago

Hi Tom, you're starting to see the start of Janis 0.11.x! There are a heap of really cool changes that are coming soon (and you're hitting a pre-release while accessing janis/dev. Some noteworthy things coming up:

I've added a commit to janis-bioinf to add an alternate extension for Fasta, and I'll deploy this to the cluster soon.

drtconway commented 3 years ago

Cheers!