PMCC-BioinformaticsCore / janis-core

Core python modules for Janis Pipeline workflow assistant
GNU General Public License v3.0
4 stars 9 forks source link

PythonTool does not handle an argument called "template" correctly. #9

Closed drtconway closed 4 years ago

drtconway commented 4 years ago

Hi Janis,

I just tried creating a PythonTool (actually a BioinformaticsPythonTool, but I don't think the distinction is relevant). The code_block method had an argument "template: String", as well as some others. Looking at the WDL generated, the python script has cli argument initializers for the other arguments, but not for "template". Changing the name of the argument made it work correctly.

It'd be ideal to have that either flagged as an error, or if "template" isn't special, then it should be handled correctly.

Cheers, Tom.