PMDCollab / PMD-collab-wiki

Sprite Collab Repository
https://sprites.pmdcollab.org/
MIT License
4 stars 5 forks source link

Feature request: Sprite/Portrait history #49

Closed Chesyon closed 1 year ago

Chesyon commented 1 year ago

It'd be very helpful if each mon's page showed it's sprite and portrait history, like the !portraithistory and !spritehistory Spritebot commands. portrait history on site mockup

keldaan-ag commented 1 year ago

If we want to solve this issue, i would need those informations in the spriteServer @theCapypara

type MonsterFormPortraits {
   """
   List of all modifications made to those portraits since its creation
   """
   history: [MonsterHistory]
  ...
}

type MonsterFormSprites {
  """
  List of all modifications made to those sprites since its creation
  """
   history: [MonsterHistory]
  ...
}

type MonsterHistory {
  credit: Credit
  modifiedDate: DateTimeUtc
  modifications: [string]
}
theCapypara commented 1 year ago

Hi! I implemented this. https://github.com/PMDCollab/spritecollab-srv/commit/3f3da05eff87254e3509d33290733f0f390589c7 Please query the history field lazily, do not load it with all Pokémon at once, only when a Pokémon is actually opened. It's not cheap to compute.

Additionally the history entries have an additional "obsolete" boolean field.

keldaan-ag commented 1 year ago

feature implemented image