search

PMEAL / OpenPNM

A Python package for performing pore network modeling of porous media
http://openpnm.org
MIT License
442 stars 175 forks source link

Refactor OrdinaryPercolation into SitePercolation and BondPercolation #1508

Closed jgostick closed 4 years ago

jgostick commented 4 years ago

The current implementation allows both, based on an adjustable setting. As I am investigating a possible bug I feel like it would be easier if the class were split. Probably would be easier for users too.

jgostick commented 4 years ago

I think this idea was a bit overzealous. There are already site and bond percolation functions in topotools, so the OrdinaryPercolation class just calls these based on settings, which I think is good enough.